third_party/WebKit/Source/core/paint/PaintLayer.h - Issue 2280963002: Fix clip-path reference box/coordinate space setup for hit-testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2280963002: Fix clip-path reference box/coordinate space setup for hit-testing (Closed)

Patch Set: Go through with test-cleanup... Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/css3/masking/clip-path-hittest-reference-usou.html ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayer.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h

index 264c5cfd584983ebd90cdce4744574b71b2b8214..0d6e9a7140be4b5b34289d410b91a8e08809e52f 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h

@@ -373,6 +373,8 @@ public:

LayoutRect physicalBoundingBoxIncludingReflectionAndStackingChildren(const LayoutPoint& offsetFromRoot, CalculateBoundsOptions = MaybeIncludeTransformForAncestorLayer) const;

LayoutRect fragmentsBoundingBox(const PaintLayer* ancestorLayer) const;

+ LayoutRect computeReferenceBox() const;

Stephen Chennney 2016/08/26 14:19:28 I think this should be named boxForReferenceHitTes

fs 2016/08/26 14:41:51 We use it when painting too, so I'd go with someth

LayoutRect boundingBoxForCompositingOverlapTest() const;

// If true, this layer's children are included in its bounds for overlap testing.