Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2280963002: Fix clip-path reference box/coordinate space setup for hit-testing (Closed)
Patch Set: Go through with test-cleanup... Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 NeverIncludeTransformForAncestorLayer, 366 NeverIncludeTransformForAncestorLayer,
367 IncludeTransformsAndCompositedChildLayers, 367 IncludeTransformsAndCompositedChildLayers,
368 }; 368 };
369 369
370 // Bounding box relative to some ancestor layer. Pass offsetFromRoot if know n. 370 // Bounding box relative to some ancestor layer. Pass offsetFromRoot if know n.
371 LayoutRect physicalBoundingBox(const LayoutPoint& offsetFromRoot) const; 371 LayoutRect physicalBoundingBox(const LayoutPoint& offsetFromRoot) const;
372 LayoutRect physicalBoundingBox(const PaintLayer* ancestorLayer) const; 372 LayoutRect physicalBoundingBox(const PaintLayer* ancestorLayer) const;
373 LayoutRect physicalBoundingBoxIncludingReflectionAndStackingChildren(const L ayoutPoint& offsetFromRoot, CalculateBoundsOptions = MaybeIncludeTransformForAnc estorLayer) const; 373 LayoutRect physicalBoundingBoxIncludingReflectionAndStackingChildren(const L ayoutPoint& offsetFromRoot, CalculateBoundsOptions = MaybeIncludeTransformForAnc estorLayer) const;
374 LayoutRect fragmentsBoundingBox(const PaintLayer* ancestorLayer) const; 374 LayoutRect fragmentsBoundingBox(const PaintLayer* ancestorLayer) const;
375 375
376 LayoutRect computeReferenceBox() const;
Stephen Chennney 2016/08/26 14:19:28 I think this should be named boxForReferenceHitTes
fs 2016/08/26 14:41:51 We use it when painting too, so I'd go with someth
377
376 LayoutRect boundingBoxForCompositingOverlapTest() const; 378 LayoutRect boundingBoxForCompositingOverlapTest() const;
377 379
378 // If true, this layer's children are included in its bounds for overlap tes ting. 380 // If true, this layer's children are included in its bounds for overlap tes ting.
379 // We can't rely on the children's positions if this layer has a filter that could have moved the children's pixels around. 381 // We can't rely on the children's positions if this layer has a filter that could have moved the children's pixels around.
380 bool overlapBoundsIncludeChildren() const; 382 bool overlapBoundsIncludeChildren() const;
381 LayoutRect boundingBoxForCompositing(const PaintLayer* ancestorLayer = 0, Ca lculateBoundsOptions = MaybeIncludeTransformForAncestorLayer) const; 383 LayoutRect boundingBoxForCompositing(const PaintLayer* ancestorLayer = 0, Ca lculateBoundsOptions = MaybeIncludeTransformForAncestorLayer) const;
382 384
383 LayoutUnit staticInlinePosition() const { return m_staticInlinePosition; } 385 LayoutUnit staticInlinePosition() const { return m_staticInlinePosition; }
384 LayoutUnit staticBlockPosition() const { return m_staticBlockPosition; } 386 LayoutUnit staticBlockPosition() const { return m_staticBlockPosition; }
385 387
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
899 901
900 } // namespace blink 902 } // namespace blink
901 903
902 #ifndef NDEBUG 904 #ifndef NDEBUG
903 // Outside the WebCore namespace for ease of invocation from gdb. 905 // Outside the WebCore namespace for ease of invocation from gdb.
904 void showLayerTree(const blink::PaintLayer*); 906 void showLayerTree(const blink::PaintLayer*);
905 void showLayerTree(const blink::LayoutObject*); 907 void showLayerTree(const blink::LayoutObject*);
906 #endif 908 #endif
907 909
908 #endif // Layer_h 910 #endif // Layer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698