Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 228093004: Implement handlified String::Flatten. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Implement handlified String::Flatten. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20572

Patch Set 1 #

Patch Set 2 : even shorter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -92 lines) Patch
M src/api.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/handles.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/handles.cc View 2 chunks +1 line, -11 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/json-stringifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/jsregexp.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/liveedit.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/objects.cc View 1 3 chunks +30 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 22 chunks +30 lines, -37 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/test-strings.cc View 8 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
This does not remove the use of the non-handlified String::TryFlatten yet. Some possibly performance sensitive ...
6 years, 8 months ago (2014-04-08 08:19:50 UTC) #1
Yang
On 2014/04/08 08:19:50, Yang wrote: > This does not remove the use of the non-handlified ...
6 years, 8 months ago (2014-04-08 09:33:25 UTC) #2
ulan
lgtm
6 years, 8 months ago (2014-04-08 09:41:43 UTC) #3
Yang
6 years, 8 months ago (2014-04-08 09:50:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20572 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698