src/objects-debug.cc - Issue 228093004: Implement handlified String::Flatten.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 228093004: Implement handlified String::Flatten. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: even shorter Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 87383c7257784d276c1d0d34599f7fe9383b6931..5d7949657b743fc8abb5324199f0e628c0fcd5d4 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -522,6 +522,7 @@ void ConsString::ConsStringVerify() {

CHECK(this->second() == GetHeap()->empty_string() ||

this->second()->IsString());

CHECK(this->length() >= ConsString::kMinLength);

+ CHECK(this->length() == this->first()->length() + this->second()->length());

if (this->IsFlat()) {

// A flat cons can only be created by String::SlowTryFlatten.

// Afterwards, the first part may be externalized.

« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »