Make toV8(ScriptValue) never return an empty handle

Make toV8(ScriptValue) never return an empty handle

I'm making toV8() never return an empty handle.
This CL replaces the return value of toV8(ScriptValue) with v8::Undefined,
but it won't change any web-exposed behavior because V8 interprets
a returned empty handle as v8::Undefined().

BUG=625512
Committed: https://crrev.com/5a94e63aa33df1b6a6e57d48c0abebe62486a30f
Cr-Commit-Position: refs/heads/master@{#414688}

[haraken, 2016-08-26 09:33:55]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2016-08-26 09:33:55]

PTAL

[Yuki, 2016-08-26 09:38:21]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2016-08-26 09:38:21]

lgtm

I'm sure you know, but just in case, there must be not few direct calls to
scriptValue.v8Value() without using toV8().

[commit-bot: I haz the power, 2016-08-26 09:38:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-08-26 09:51:34]

> I'm sure you know, but just in case, there must be not few direct calls to
> scriptValue.v8Value() without using toV8().

Yes. That is okay since an empty handle is treated as v8::Undefined in V8.

[haraken, 2016-08-26 09:52:22]

On 2016/08/26 09:51:34, haraken wrote:
> > I'm sure you know, but just in case, there must be not few direct calls to
> > scriptValue.v8Value() without using toV8().
> 
> Yes. That is okay since an empty handle is treated as v8::Undefined in V8.

Just to clarify: I need to make sure that toV8() never returns an empty handle
before landing https://codereview.chromium.org/2267403006/.

[Yuki, 2016-08-26 10:01:53]

On 2016/08/26 09:52:22, haraken wrote:
> On 2016/08/26 09:51:34, haraken wrote:
> > > I'm sure you know, but just in case, there must be not few direct calls to
> > > scriptValue.v8Value() without using toV8().
> > 
> > Yes. That is okay since an empty handle is treated as v8::Undefined in V8.
> 
> Just to clarify: I need to make sure that toV8() never returns an empty handle
> before landing https://codereview.chromium.org/2267403006/.

Got it.  Thanks for the elaboration.

[commit-bot: I haz the power, 2016-08-26 11:55:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-26 11:57:07]

Description was changed from

==========
Make toV8(ScriptValue) never return an empty handle

I'm making toV8() never return an empty handle.
This CL replaces the return value of toV8(ScriptValue) with v8::Undefined,
but it won't change any web-exposed behavior because V8 interprets
a returned empty handle as v8::Undefined().

BUG=625512
==========

to

==========
Make toV8(ScriptValue) never return an empty handle

I'm making toV8() never return an empty handle.
This CL replaces the return value of toV8(ScriptValue) with v8::Undefined,
but it won't change any web-exposed behavior because V8 interprets
a returned empty handle as v8::Undefined().

BUG=625512

Committed: https://crrev.com/5a94e63aa33df1b6a6e57d48c0abebe62486a30f
Cr-Commit-Position: refs/heads/master@{#414688}
==========

[commit-bot: I haz the power, 2016-08-26 11:57:08]

Patchset 1 (id:??) landed as
https://crrev.com/5a94e63aa33df1b6a6e57d48c0abebe62486a30f
Cr-Commit-Position: refs/heads/master@{#414688}