Make toV8(ScriptValue) never return an empty handle

third_party/WebKit/Source/bindings/core/v8/ToV8.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ToV8_h
 #define ToV8_h
 
 // toV8() provides C++ -> V8 conversion. Note that toV8() can return an empty
 // handle. Call sites must check IsEmpty() before using return value.
 
@@ skipping 167 matching lines @@
     DISALLOW_NEW();
 }; // Used only for having toV8 return v8::Undefined.
 
 inline v8::Local<v8::Value> toV8(const ToV8UndefinedGenerator&  value, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     return v8::Undefined(isolate);
 }
 
 // ScriptValue
 
-inline v8::Local<v8::Value> toV8(const ScriptValue& value, v8::Local<v8::Object> creationContext, v8::Isolate*)
+inline v8::Local<v8::Value> toV8(const ScriptValue& value, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
+    if (value.isEmpty())
+        return v8::Undefined(isolate);
     return value.v8Value();
 }
 
 // Dictionary
 
-inline v8::Local<v8::Value> toV8(const Dictionary& value, v8::Local<v8::Object> creationContext, v8::Isolate*)
+inline v8::Local<v8::Value> toV8(const Dictionary& value, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
-    RELEASE_NOTREACHED();
-    return v8::Local<v8::Value>();
+    NOTREACHED();
+    return v8::Undefined(isolate);
 }
 
 inline v8::Local<v8::Value> toV8(const IDLDictionaryBase& value, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     return value.toV8Impl(creationContext, isolate);
 }
 
 // Array
 
 template<typename Sequence>
@@ skipping 68 matching lines @@
 // Cannot define in ScriptValue because of the circular dependency between toV8 and ScriptValue
 template<typename T>
 inline ScriptValue ScriptValue::from(ScriptState* scriptState, T&& value)
 {
     return ScriptValue(scriptState, toV8(std::forward<T>(value), scriptState));
 }
 
 } // namespace blink
 
 #endif // ToV8_h