Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2280823002: cc: Remove right quad for fullscreen overlays. (Closed)

Created:
4 years, 3 months ago by Daniele Castagna
Modified:
4 years, 3 months ago
Reviewers:
reveman
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove right quad for fullscreen overlays. When a fullscreen quad is promoted to overlay, it should be removed from quad_list to be GL composited. This CL fixes a bug where OverlayStrategyFullscreen assumed that the first quad would always be the one to remove. BUG=b/29430506 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/7c8c70e76262bd9a2cfc45cd85a10cdeb69a25ea Cr-Commit-Position: refs/heads/master@{#414759}

Patch Set 1 #

Patch Set 2 : Add unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M cc/output/overlay_strategy_fullscreen.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/overlay_unittest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Daniele Castagna
We were still GL compositing even when we were replacing the main plane. This patch ...
4 years, 3 months ago (2016-08-26 01:22:49 UTC) #6
reveman
lgtm
4 years, 3 months ago (2016-08-26 01:37:37 UTC) #7
reveman
On 2016/08/26 at 01:37:37, reveman wrote: > lgtm would be awesome if you could also ...
4 years, 3 months ago (2016-08-26 03:05:02 UTC) #8
Daniele Castagna
On 2016/08/26 at 03:05:02, reveman wrote: > On 2016/08/26 at 01:37:37, reveman wrote: > > ...
4 years, 3 months ago (2016-08-26 03:17:04 UTC) #10
reveman
lgtm
4 years, 3 months ago (2016-08-26 16:34:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280823002/20001
4 years, 3 months ago (2016-08-26 16:34:55 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 18:44:39 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:16:16 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c8c70e76262bd9a2cfc45cd85a10cdeb69a25ea
Cr-Commit-Position: refs/heads/master@{#414759}

Powered by Google App Engine
This is Rietveld 408576698