cc/output/overlay_strategy_fullscreen.cc - Issue 2280823002: cc: Remove right quad for fullscreen overlays.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/output/overlay_strategy_fullscreen.cc

Issue 2280823002: cc: Remove right quad for fullscreen overlays. (Closed)

Patch Set: Add unit test. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | cc/output/overlay_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "cc/output/overlay_strategy_fullscreen.h"	5 #include "cc/output/overlay_strategy_fullscreen.h"

6	6

7 #include "cc/base/math_util.h"	7 #include "cc/base/math_util.h"

8 #include "cc/output/overlay_candidate_validator.h"	8 #include "cc/output/overlay_candidate_validator.h"

9 #include "cc/quads/draw_quad.h"	9 #include "cc/quads/draw_quad.h"

10 #include "cc/quads/solid_color_draw_quad.h"	10 #include "cc/quads/solid_color_draw_quad.h"

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 if (!candidate.display_rect.origin().IsOrigin() \|\|	44 if (!candidate.display_rect.origin().IsOrigin() \|\|

45 gfx::ToRoundedSize(candidate.display_rect.size()) !=	45 gfx::ToRoundedSize(candidate.display_rect.size()) !=

46 render_pass->output_rect.size() \|\|	46 render_pass->output_rect.size() \|\|

47 render_pass->output_rect.size() != candidate.resource_size_in_pixels) {	47 render_pass->output_rect.size() != candidate.resource_size_in_pixels) {

48 return false;	48 return false;

49 }	49 }

50	50

51 candidate.plane_z_order = 1;	51 candidate.plane_z_order = 1;

52 candidate.overlay_handled = true;	52 candidate.overlay_handled = true;

53 candidate_list->push_back(candidate);	53 candidate_list->push_back(candidate);

54 quad_list->EraseAndInvalidateAllPointers(quad_list->begin());	54 quad_list->EraseAndInvalidateAllPointers(front);

55 return true;	55 return true;

56 }	56 }

57	57

58 } // namespace cc	58 } // namespace cc

OLD	NEW