Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2280743003: implement kernel -> ssa for function that returns a constant (Closed)

Created:
4 years, 3 months ago by Harry Terkelsen
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

implement kernel -> ssa for function that returns a constant R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/17f14d839a8c7d58b264a7dfedc834c5ee93ae22

Patch Set 1 #

Total comments: 2

Patch Set 2 : add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -16 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +0 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 2 chunks +43 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/kernel/simple_function_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years, 3 months ago (2016-08-26 00:41:26 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2280743003/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2280743003/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode153 pkg/compiler/lib/src/ssa/builder_kernel.dart:153: closeAndGotoExit(new HReturn(value, null)); also add TODO that once ...
4 years, 3 months ago (2016-08-26 00:57:14 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/2280743003/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2280743003/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode153 pkg/compiler/lib/src/ssa/builder_kernel.dart:153: closeAndGotoExit(new HReturn(value, null)); On 2016/08/26 00:57:14, Siggi Cherem (dart-lang) ...
4 years, 3 months ago (2016-08-26 17:29:07 UTC) #4
Harry Terkelsen
4 years, 3 months ago (2016-08-26 17:29:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
17f14d839a8c7d58b264a7dfedc834c5ee93ae22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698