Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2280743003: implement kernel -> ssa for function that returns a constant (Closed)
Patch Set: add todo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/builder_kernel.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index e44ebf3b6c1d1a683aa13237b7c036c16af89fbe..2dc48955cddbb2f54726f3cec0840c53e869747f 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -417,9 +417,6 @@ class SsaBuilder extends ast.Visitor
Map<JumpTarget, JumpHandler> jumpTargets = <JumpTarget, JumpHandler>{};
- // We build the Ssa graph by simulating a stack machine.
- List<HInstruction> stack = <HInstruction>[];
-
/// Returns `true` if the current element is an `async` function.
bool get isBuildingAsyncFunction {
Element element = sourceElement;
@@ -1906,23 +1903,10 @@ class SsaBuilder extends ast.Visitor
return graph;
}
- void push(HInstruction instruction) {
- add(instruction);
- stack.add(instruction);
- }
-
void pushWithPosition(HInstruction instruction, ast.Node node) {
push(attachPosition(instruction, node));
}
- HInstruction pop() {
- return stack.removeLast();
- }
-
- void dup() {
- stack.add(stack.last);
- }
-
HInstruction popBoolified() {
HInstruction value = pop();
if (_checkOrTrustTypes) {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/builder_kernel.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698