[turbofan] Separate typed optimizations from JSTypedLowering.

[turbofan] Separate typed optimizations from JSTypedLowering.

Introduce a new TypedOptimization reducer that contains the type
based optimization reduction steps, which are not (directly)
related to lowering JavaScript operators based on types (which is
what JSTypedLowering is supposed to do).

This also addresses a chicken-and-egg problem that we see in the
Octane/Mandreel benchmark where type based constant folding isn't
applied to the numeric comparison operators introduced by the
JSTypedLowering itself, and thus gives up to 10% speedup for the
benchmark.

BUG=v8:5267
Committed: https://crrev.com/f154c75a39308be6253de351bd4422033ba528fe
Cr-Commit-Position: refs/heads/master@{#38928}

[Benedikt Meurer, 2016-08-26 05:40:11]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 05:40:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 06:02:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 06:02:03]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-08-26 07:30:56]

bmeurer@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Benedikt Meurer, 2016-08-26 07:30:56]

Hey Michi,

This is a refactoring, plus a small performance improvement.
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2016-08-26 07:52:14]

LGTM.

https://codereview.chromium.org/2280673003/diff/1/src/compiler/typed-optimiza...
File src/compiler/typed-optimization.h (right):

https://codereview.chromium.org/2280673003/diff/1/src/compiler/typed-optimiza...
src/compiler/typed-optimization.h:5: #ifndef V8_COMPILER_TYPED_OPTIMIZATION_H_
nit: Since this is targetting JS-level nodes, can we call this file
js-typed-optimization.h, to stick with the existing naming convention?

[Benedikt Meurer, 2016-08-26 07:53:58]

https://codereview.chromium.org/2280673003/diff/1/src/compiler/typed-optimiza...
File src/compiler/typed-optimization.h (right):

https://codereview.chromium.org/2280673003/diff/1/src/compiler/typed-optimiza...
src/compiler/typed-optimization.h:5: #ifndef V8_COMPILER_TYPED_OPTIMIZATION_H_
As discussed offline, we're targetting mostly simplified operators.

[Benedikt Meurer, 2016-08-26 07:54:09]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-08-26 07:54:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 07:58:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-26 07:58:33]

Description was changed from

==========
[turbofan] Separate typed optimizations from JSTypedLowering.

Introduce a new TypedOptimization reducer that contains the type
based optimization reduction steps, which are not (directly)
related to lowering JavaScript operators based on types (which is
what JSTypedLowering is supposed to do).

This also addresses a chicken-and-egg problem that we see in the
Octane/Mandreel benchmark where type based constant folding isn't
applied to the numeric comparison operators introduced by the
JSTypedLowering itself, and thus gives up to 10% speedup for the
benchmark.

BUG=v8:5267
==========

to

==========
[turbofan] Separate typed optimizations from JSTypedLowering.

Introduce a new TypedOptimization reducer that contains the type
based optimization reduction steps, which are not (directly)
related to lowering JavaScript operators based on types (which is
what JSTypedLowering is supposed to do).

This also addresses a chicken-and-egg problem that we see in the
Octane/Mandreel benchmark where type based constant folding isn't
applied to the numeric comparison operators introduced by the
JSTypedLowering itself, and thus gives up to 10% speedup for the
benchmark.

BUG=v8:5267

Committed: https://crrev.com/f154c75a39308be6253de351bd4422033ba528fe
Cr-Commit-Position: refs/heads/master@{#38928}
==========

[commit-bot: I haz the power, 2016-08-26 07:58:33]

Patchset 1 (id:??) landed as
https://crrev.com/f154c75a39308be6253de351bd4422033ba528fe
Cr-Commit-Position: refs/heads/master@{#38928}