Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2279213002: [turbofan] Introduce a dedicated ArrayBufferWasNeutered operator. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce a dedicated ArrayBufferWasNeutered operator. Using the dedicated simplified operator we are able to eliminate redundant neuterung checks as long as there is no call in the effect chain. This yields a nice speed up for the Octane Mandreel benchmark (and TypedArray-heavy workloads in general). R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/76f740b2642032d449832b727e1fc3d70734c086 Cr-Commit-Position: refs/heads/master@{#38932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -26 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M src/compiler/load-elimination.h View 3 chunks +36 lines, -0 lines 0 comments Download
M src/compiler/load-elimination.cc View 7 chunks +102 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-26 07:57:03 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some nice improvement for Mandreel (and typed arrays in general). Please take ...
4 years, 3 months ago (2016-08-26 07:58:46 UTC) #4
Jarin
lgtm
4 years, 3 months ago (2016-08-26 08:17:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279213002/1
4 years, 3 months ago (2016-08-26 08:24:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 08:34:46 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 08:35:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76f740b2642032d449832b727e1fc3d70734c086
Cr-Commit-Position: refs/heads/master@{#38932}

Powered by Google App Engine
This is Rietveld 408576698