Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2280503002: arc: Stop piggybacking "text input started" and "show virtual keyboard" events. (Closed)

Created:
4 years, 4 months ago by kinaba
Modified:
4 years, 4 months ago
Reviewers:
takaoka, hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Stop piggybacking "text input started" and "show virtual keyboard" events. It is not only useless in the latest version, but is even harmful for some advanced apps that take the liberty of splitting these two events. This change itself should not change any observable behavior yet, but will be necessary to enable coming Android-side change to make this split effective. BUG=640816 BUG=b/31001453 TEST=ArcImeServiceTest TEST=Tested manually with some ARC apps (Settings, PlayStore) Committed: https://crrev.com/17a7a0c83e3615a6f8ad9d56e4b82006b53660ff Cr-Commit-Position: refs/heads/master@{#414283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M components/arc/ime/arc_ime_service.cc View 1 chunk +1 line, -8 lines 0 comments Download
M components/arc/ime/arc_ime_service_unittest.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
kinaba
PTAL: takaoka, hidehiko
4 years, 4 months ago (2016-08-25 00:28:02 UTC) #3
takaoka
lgtm Thank you for taking care the TODO.
4 years, 4 months ago (2016-08-25 00:42:05 UTC) #5
hidehiko
lgtm
4 years, 4 months ago (2016-08-25 00:48:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280503002/1
4 years, 4 months ago (2016-08-25 03:07:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 03:13:17 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 03:17:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17a7a0c83e3615a6f8ad9d56e4b82006b53660ff
Cr-Commit-Position: refs/heads/master@{#414283}

Powered by Google App Engine
This is Rietveld 408576698