arc: Stop piggybacking "text input started" and "show virtual keyboard" events.

components/arc/ime/arc_ime_service_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/ime/arc_ime_service.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 124 matching lines @@
   EXPECT_TRUE(instance_->HasCompositionText());
   instance_->SetCompositionText(ui::CompositionText());
   EXPECT_FALSE(instance_->HasCompositionText());
 }
 
 TEST_F(ArcImeServiceTest, ShowImeIfNeeded) {
   fake_input_method_->SetFocusedTextInputClient(instance_.get());
   instance_->OnTextInputTypeChanged(ui::TEXT_INPUT_TYPE_NONE);
   ASSERT_EQ(0, fake_input_method_->count_show_ime_if_needed());
 
+  // Text input type change does not imply the show ime request.
   instance_->OnTextInputTypeChanged(ui::TEXT_INPUT_TYPE_TEXT);
+  EXPECT_EQ(0, fake_input_method_->count_show_ime_if_needed());
+
+  instance_->ShowImeIfNeeded();
   EXPECT_EQ(1, fake_input_method_->count_show_ime_if_needed());
-
-  // The type is not changing, hence no call.
-  instance_->OnTextInputTypeChanged(ui::TEXT_INPUT_TYPE_TEXT);
-  EXPECT_EQ(1, fake_input_method_->count_show_ime_if_needed());
-
-  instance_->OnTextInputTypeChanged(ui::TEXT_INPUT_TYPE_SEARCH);
-  EXPECT_EQ(2, fake_input_method_->count_show_ime_if_needed());
-
-  // Change to NONE should not trigger the showing event.
-  instance_->OnTextInputTypeChanged(ui::TEXT_INPUT_TYPE_NONE);
-  EXPECT_EQ(2, fake_input_method_->count_show_ime_if_needed());
 }
 
 TEST_F(ArcImeServiceTest, CancelComposition) {
   // The bridge should forward the cancel event to the input method.
   fake_input_method_->SetFocusedTextInputClient(instance_.get());
   instance_->OnCancelComposition();
   EXPECT_EQ(1, fake_input_method_->count_cancel_composition());
 }
 
 TEST_F(ArcImeServiceTest, InsertChar) {
   fake_input_method_->SetFocusedTextInputClient(instance_.get());
 
   // When text input type is NONE, the event is not forwarded.
   instance_->OnTextInputTypeChanged(ui::TEXT_INPUT_TYPE_NONE);
   instance_->InsertChar(ui::KeyEvent('a', ui::VKEY_A, 0));
   EXPECT_EQ(0, fake_arc_ime_bridge_->count_send_insert_text());
 
   // When the bridge is accepting text inputs, forward the event.
   instance_->OnTextInputTypeChanged(ui::TEXT_INPUT_TYPE_TEXT);
   instance_->InsertChar(ui::KeyEvent('a', ui::VKEY_A, 0));
   EXPECT_EQ(1, fake_arc_ime_bridge_->count_send_insert_text());
 }
 
 }  // namespace arc