Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4165)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2280473002: Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: kSmallSize -> crash_keys::kSmallSize to fix blimp compile error Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client_win.cc
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc
index 2d9e24bde5b9f1619543d680cb497a90eb73fe3e..94f55772eaf1253b947cadbd7c6f2c3bb80bc54d 100644
--- a/chrome/app/chrome_crash_reporter_client_win.cc
+++ b/chrome/app/chrome_crash_reporter_client_win.cc
@@ -138,6 +138,16 @@ size_t RegisterCrashKeysHelper() {
{"initrf_root_process_is_live", kSmallSize},
{"initrf_root_proxy_is_live", kSmallSize},
+ // Temporary for https://crbug.com/626802.
+ { "newframe_routing_id", kSmallSize },
+ { "newframe_proxy_id", kSmallSize },
+ { "newframe_opener_id", kSmallSize },
+ { "newframe_parent_id", kSmallSize },
+ { "newframe_widget_id", kSmallSize },
+ { "newframe_widget_hidden", kSmallSize },
+ { "newframe_replicated_origin", kSmallSize },
+ { "newframe_oopifs_possible", kSmallSize },
+
// Temporary for https://crbug.com/630103.
{ "origin_mismatch_url", crash_keys::kLargeSize },
{ "origin_mismatch_origin", crash_keys::kMediumSize },
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698