Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2280293002: Hide ash palette on lock screen, show it in guest mode. (Closed)

Created:
4 years, 3 months ago by jdufault
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide ash palette on lock screen, show it in guest mode. TEST=manual BUG=638994 Committed: https://crrev.com/a32300920a1c997653dadded5c66e07854370864 Cr-Commit-Position: refs/heads/master@{#415209}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ash/common/system/chromeos/palette/palette_tray.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
jdufault
oshima@ PTAL. Thanks!
4 years, 3 months ago (2016-08-27 00:22:45 UTC) #5
oshima
lgtm
4 years, 3 months ago (2016-08-27 01:01:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280293002/1
4 years, 3 months ago (2016-08-29 18:58:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:15:36 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:17:36 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a32300920a1c997653dadded5c66e07854370864
Cr-Commit-Position: refs/heads/master@{#415209}

Powered by Google App Engine
This is Rietveld 408576698