Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2280273002: Disable magnification palette tool unless experimental palette features are enabled. (Closed)

Created:
4 years, 3 months ago by jdufault
Modified:
4 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable magnification palette tool unless experimental palette features are enabled. TEST=manual BUG=641603 Committed: https://crrev.com/390ccf8ff50b6ff69c2339076a410c7c7f70a357 Cr-Commit-Position: refs/heads/master@{#414883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M ash/common/ash_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/ash_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tool.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/common/system/chromeos/palette/palette_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_utils.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
jdufault
jamescook@ PTAL when you get a chance.
4 years, 3 months ago (2016-08-27 00:21:45 UTC) #7
James Cook
LGTM
4 years, 3 months ago (2016-08-27 01:01:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280273002/1
4 years, 3 months ago (2016-08-27 01:05:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 10:24:34 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 10:28:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/390ccf8ff50b6ff69c2339076a410c7c7f70a357
Cr-Commit-Position: refs/heads/master@{#414883}

Powered by Google App Engine
This is Rietveld 408576698