Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: scripts/slave/recipes/run_presubmit.py

Issue 2280153003: Remove svn test from run_presubmit recipe module (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/run_presubmit.expected/fake_svn_master.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/run_presubmit.py
diff --git a/scripts/slave/recipes/run_presubmit.py b/scripts/slave/recipes/run_presubmit.py
index 861a7a4b10e42dea069fdc63f5980c678d53aedf..40d10605abf92d33c42a953df2e2bc5fdc063572 100644
--- a/scripts/slave/recipes/run_presubmit.py
+++ b/scripts/slave/recipes/run_presubmit.py
@@ -39,12 +39,6 @@ def _RunStepsInternal(api):
got_revision_property = api.gclient.c.got_revision_mapping[relative_root]
upstream = bot_update_step.json.output['properties'].get(
got_revision_property)
- if (not upstream or
- isinstance(upstream, int) or
- (upstream.isdigit() and len(upstream) < 40)):
- # If got_revision is an svn revision, then use got_revision_git.
- upstream = bot_update_step.json.output['properties'].get(
- '%s_git' % got_revision_property) or ''
abs_root = api.path['slave_build'].join(relative_root)
# TODO(hinoka): Extract email/name from issue?
@@ -140,17 +134,6 @@ def GenTests(api):
)
yield (
- api.test('fake_svn_master') +
- api.properties.tryserver(
- mastername='experimental.svn',
- buildername='chromium_presubmit',
- repo_name='chromium',
- force_checkout=True) +
- api.step_data('presubmit', api.json.output([['chromium_presubmit',
- ['compile']]]))
- )
-
- yield (
api.test('chromium_dry_run') +
api.properties.tryserver(
mastername='tryserver.chromium.linux',
« no previous file with comments | « no previous file | scripts/slave/recipes/run_presubmit.expected/fake_svn_master.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698