Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 22801019: Provide i18n support for descriptions in commands API. (Closed)

Created:
7 years, 4 months ago by zhchbin
Modified:
7 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, jshin+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Provide i18n support for descriptions in commands API. BUG=277497 TEST=unit_tests --gtest_filter=ExtensionL10nUtil.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M chrome/common/extensions/extension_l10n_util.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util_unittest.cc View 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zhchbin
Please review.
7 years, 4 months ago (2013-08-23 02:26:25 UTC) #1
Yoyo Zhou
LGTM Thanks!
7 years, 4 months ago (2013-08-23 04:17:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/22801019/1
7 years, 4 months ago (2013-08-23 04:27:09 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 07:55:57 UTC) #4
Message was sent while issue was closed.
Change committed as 219253

Powered by Google App Engine
This is Rietveld 408576698