Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2279883004: Revert of Settings People: Add /signOut route for Disconnect dialog. (Closed)

Created:
4 years, 3 months ago by jianli
Modified:
4 years, 3 months ago
Reviewers:
tommycli, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Settings People: Add /signOut route for Disconnect dialog. (patchset #2 id:20001 of https://codereview.chromium.org/2271843002/ ) Reason for revert: The following browser test failed: CrSettingsPeoplePageTest.PeoplePage https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/32657 Original issue's description: > Settings People: Add /signOut route for Disconnect dialog. > > BUG=640199 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/54a670192c726f5762109842c0ecc958ad045256 > Cr-Commit-Position: refs/heads/master@{#414562} TBR=michaelpg@chromium.org,tommycli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=640199 Committed: https://crrev.com/5bb6b2df54d7a4b3dbd76aa59d64747ad886d58f Cr-Commit-Position: refs/heads/master@{#414596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 4 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/route.js View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/webui/settings/people_page_test.js View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jianli
Created Revert of Settings People: Add /signOut route for Disconnect dialog.
4 years, 3 months ago (2016-08-26 00:23:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279883004/1
4 years, 3 months ago (2016-08-26 00:24:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 00:25:30 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 00:31:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bb6b2df54d7a4b3dbd76aa59d64747ad886d58f
Cr-Commit-Position: refs/heads/master@{#414596}

Powered by Google App Engine
This is Rietveld 408576698