Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2481)

Unified Diff: chrome/browser/resources/settings/route.js

Issue 2279883004: Revert of Settings People: Add /signOut route for Disconnect dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/route.js
diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js
index 07b56ba492502dfb9bb73548d8dff23c37a1024c..4aa02d0706bc6092c5713fc47c81e4f375347a3d 100644
--- a/chrome/browser/resources/settings/route.js
+++ b/chrome/browser/resources/settings/route.js
@@ -91,11 +91,6 @@
r.ADVANCED = new Route('/advanced');
r.ABOUT = new Route('/help');
- // Navigable dialogs. These are the only non-section children of root pages.
- // These are disfavored. If we add anymore, we should add explicit support.
- r.SIGN_OUT = r.BASIC.createChild('/signOut');
- r.CLEAR_BROWSER_DATA = r.ADVANCED.createChild('/clearBrowserData');
-
<if expr="chromeos">
r.INTERNET = r.BASIC.createSection('/internet', 'internet');
r.NETWORK_DETAIL = r.INTERNET.createChild('/networkDetail');
@@ -132,6 +127,11 @@
r.PRIVACY = r.ADVANCED.createSection('/privacy', 'privacy');
r.CERTIFICATES = r.PRIVACY.createChild('/certificates');
+
+ // CLEAR_BROWSER_DATA is the only navigable dialog route. It's the only child
+ // of a root page that's not a section. Don't add any more routes like these.
+ // If more navigable dialogs are needed, add explicit support in Route.
+ r.CLEAR_BROWSER_DATA = r.ADVANCED.createChild('/clearBrowserData');
r.SITE_SETTINGS = r.PRIVACY.createChild('/siteSettings');
r.SITE_SETTINGS_ALL = r.SITE_SETTINGS.createChild('all');
« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.js ('k') | chrome/test/data/webui/settings/people_page_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698