Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2279773002: [parser] Clean up type definitions (Closed)

Created:
4 years, 3 months ago by nickie
Modified:
4 years, 3 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Clean up type definitions This patch: 1. Removes the unecessary inheritance of ParserBaseTraits<Impl> in ParserBase<Impl>. 2. Flattens ParserBaseTraits<Impl> and renames it to ParserTypes<Impl>. The Traits parameter/member is renamed to Types. 3. Removes unecessary v8::internal:: qualifications from parser types. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Committed: https://crrev.com/58cfe4d6182c6acb30aa6d62592e62d57a7fd879 Cr-Commit-Position: refs/heads/master@{#38927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -185 lines) Patch
M src/parsing/expression-classifier.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/parsing/parser.h View 7 chunks +42 lines, -48 lines 0 comments Download
M src/parsing/parser.cc View 6 chunks +11 lines, -17 lines 0 comments Download
M src/parsing/parser-base.h View 15 chunks +70 lines, -79 lines 0 comments Download
M src/parsing/preparser.h View 6 chunks +42 lines, -38 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
nickie
4 years, 3 months ago (2016-08-25 12:32:40 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-08-25 15:50:32 UTC) #6
marja
lgtm
4 years, 3 months ago (2016-08-26 07:27:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279773002/1
4 years, 3 months ago (2016-08-26 07:43:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 07:45:59 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 07:46:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58cfe4d6182c6acb30aa6d62592e62d57a7fd879
Cr-Commit-Position: refs/heads/master@{#38927}

Powered by Google App Engine
This is Rietveld 408576698