[parser] Eliminate ExpressionClassifier::MergeNonPatterns

[parser] Eliminate ExpressionClassifier::MergeNonPatterns

A minor change in the logic of expression classifiers that
eliminates the use for MergeNonPatterns.

R=adamk@chromium.org, littledan@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/8ce447510370e427be6e35f2afcb7fa32e9c82fa
Cr-Commit-Position: refs/heads/master@{#38934}

[nickie, 2016-08-25 13:58:29]

I just realized I made this PS dependent to 2279773002.
It was not my intention, this patch is unrelated.
Sorry about that.

[nickie, 2016-08-25 14:24:11]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 14:24:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 15:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 15:03:23]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-25 16:09:15]

lgtm

https://codereview.chromium.org/2275313002/diff/20001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2275313002/diff/20001/src/parsing/parser-base...
src/parsing/parser-base.h:2389: // Do not merge pending non-pattern expressions
yet!
Please remove this comment while you're at it (I probably should have removed it
myself, or at least moved it down).

[nickie, 2016-08-26 07:57:36]

https://codereview.chromium.org/2275313002/diff/20001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2275313002/diff/20001/src/parsing/parser-base...
src/parsing/parser-base.h:2389: // Do not merge pending non-pattern expressions
yet!
On 2016/08/25 16:09:15, adamk wrote:
> Please remove this comment while you're at it (I probably should have removed
it
> myself, or at least moved it down).

Removed.  Covered by the comment on line 2421.

[nickie, 2016-08-26 07:57:58]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-08-26 07:58:08]

The CQ bit was unchecked by nikolaos@chromium.org

[commit-bot: I haz the power, 2016-08-26 07:58:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nickie, 2016-08-26 07:59:23]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-08-26 07:59:24]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2275313002/#ps40001
(title: "Changes after reviewers' comments")

[commit-bot: I haz the power, 2016-08-26 07:59:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 08:02:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 08:02:31]

Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/7719)

[nickie, 2016-08-26 08:26:41]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-08-26 08:26:41]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2275313002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-26 08:26:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 08:57:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 08:57:58]

Description was changed from

==========
[parser] Eliminate ExpressionClassifier::MergeNonPatterns

A minor change in the logic of expression classifiers that
eliminates the use for MergeNonPatterns.

R=adamk@chromium.org, littledan@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Eliminate ExpressionClassifier::MergeNonPatterns

A minor change in the logic of expression classifiers that
eliminates the use for MergeNonPatterns.

R=adamk@chromium.org, littledan@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/8ce447510370e427be6e35f2afcb7fa32e9c82fa
Cr-Commit-Position: refs/heads/master@{#38934}
==========

[commit-bot: I haz the power, 2016-08-26 08:57:59]

Patchset 4 (id:??) landed as
https://crrev.com/8ce447510370e427be6e35f2afcb7fa32e9c82fa
Cr-Commit-Position: refs/heads/master@{#38934}