Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2279763003: Revert "Move WebSocketHandleImpl into Blink" (Closed)

Created:
4 years, 3 months ago by darin (slow to review)
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, yhirano
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tyoshino+watch_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, kinuko+watch, viettrungluu+watch_chromium.org, yhirano+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, blink-reviews, blink-reviews-api_chromium.org, darin (slow to review), Nate Chapin, loading-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Move WebSocketHandleImpl into Blink" This reverts commit b8df2228b7039e0326e6098e74547539fe9ef4e0 due to a link error on the "Android Builder" main waterfall bot. TBR=yhirano@chromium.org,tsepez@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/c2fb7d7326813eca1ef5d185f4da5f92c93af025 Cr-Commit-Position: refs/heads/master@{#414459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+661 lines, -759 lines) Patch
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/websockets/websocket_impl.h View 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/websockets/websocket_impl.cc View 6 chunks +19 lines, -19 lines 0 comments Download
M content/browser/websockets/websocket_manager.h View 3 chunks +10 lines, -7 lines 0 comments Download
M content/browser/websockets/websocket_manager.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/websockets/websocket_manager_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + content/common/websocket.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A content/renderer/websockethandle_impl.h View 1 chunk +86 lines, -0 lines 0 comments Download
A content/renderer/websockethandle_impl.cc View 1 chunk +308 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h View 3 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 8 chunks +22 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 7 chunks +20 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/modules/websockets/WebSocketHandle.h View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/WebKit/Source/modules/websockets/WebSocketHandle.cpp View 1 chunk +0 lines, -253 lines 0 comments Download
D third_party/WebKit/Source/modules/websockets/WebSocketHandleClient.h View 1 chunk +0 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/exported/WebSocketHandshakeRequestInfo.cpp View 1 chunk +21 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/platform/exported/WebSocketHandshakeResponseInfo.cpp View 1 chunk +21 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/websockets/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
A + third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h View 1 chunk +27 lines, -27 lines 0 comments Download
A + third_party/WebKit/public/platform/modules/websockets/WebSocketHandleClient.h View 2 chunks +12 lines, -10 lines 0 comments Download
A + third_party/WebKit/public/platform/modules/websockets/WebSocketHandshakeRequestInfo.h View 1 chunk +19 lines, -14 lines 0 comments Download
A + third_party/WebKit/public/platform/modules/websockets/WebSocketHandshakeResponseInfo.h View 1 chunk +18 lines, -13 lines 0 comments Download
D third_party/WebKit/public/platform/modules/websockets/websocket.mojom View 1 chunk +0 lines, -138 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279763003/1
4 years, 3 months ago (2016-08-25 16:58:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 17:04:18 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 17:06:31 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c2fb7d7326813eca1ef5d185f4da5f92c93af025
Cr-Commit-Position: refs/heads/master@{#414459}

Powered by Google App Engine
This is Rietveld 408576698