Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Unified Diff: third_party/WebKit/public/platform/modules/websockets/WebSocketHandleClient.h

Issue 2279763003: Revert "Move WebSocketHandleImpl into Blink" (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/websockets/WebSocketHandleClient.h
diff --git a/third_party/WebKit/Source/modules/websockets/WebSocketHandleClient.h b/third_party/WebKit/public/platform/modules/websockets/WebSocketHandleClient.h
similarity index 81%
rename from third_party/WebKit/Source/modules/websockets/WebSocketHandleClient.h
rename to third_party/WebKit/public/platform/modules/websockets/WebSocketHandleClient.h
index 765e9f90d685317d620c0ba347cef4076c33bfbb..249d5d02cb289fbbe7555b5d9e50261d518c87c9 100644
--- a/third_party/WebKit/Source/modules/websockets/WebSocketHandleClient.h
+++ b/third_party/WebKit/public/platform/modules/websockets/WebSocketHandleClient.h
@@ -31,26 +31,28 @@
#ifndef WebSocketHandleClient_h
#define WebSocketHandleClient_h
-#include "modules/websockets/WebSocketHandle.h"
-#include "wtf/Forward.h"
+#include "public/platform/WebCommon.h"
+#include "public/platform/WebString.h"
+#include "public/platform/modules/websockets/WebSocketHandle.h"
namespace blink {
-class WebSocketHandshakeRequest;
-class WebSocketHandshakeResponse;
+
+class WebSocketHandshakeRequestInfo;
+class WebSocketHandshakeResponseInfo;
class WebSocketHandleClient {
public:
// Called when the handle is opened.
- virtual void didConnect(WebSocketHandle*, const String& selectedProtocol, const String& extensions) = 0;
+ virtual void didConnect(WebSocketHandle*, const WebString& selectedProtocol, const WebString& extensions) = 0;
// Called when the browser starts the opening handshake.
// This notification can be omitted when the inspector is not active.
- virtual void didStartOpeningHandshake(WebSocketHandle*, PassRefPtr<WebSocketHandshakeRequest>) = 0;
+ virtual void didStartOpeningHandshake(WebSocketHandle*, const WebSocketHandshakeRequestInfo&) = 0;
// Called when the browser finishes the opening handshake.
// This notification precedes didConnect.
// This notification can be omitted when the inspector is not active.
- virtual void didFinishOpeningHandshake(WebSocketHandle*, const WebSocketHandshakeResponse*) = 0;
+ virtual void didFinishOpeningHandshake(WebSocketHandle*, const WebSocketHandshakeResponseInfo&) = 0;
// Called when the browser is required to fail the connection.
// |message| can be displayed in the inspector, but should not be passed
@@ -58,14 +60,14 @@ public:
// This message also implies that channel is closed with
// (wasClean = false, code = 1006, reason = "") and
// |handle| becomes unavailable.
- virtual void didFail(WebSocketHandle* /* handle */, const String& message) = 0;
+ virtual void didFail(WebSocketHandle* /* handle */, const WebString& message) = 0;
// Called when data are received.
- virtual void didReceiveData(WebSocketHandle*, bool fin, WebSocketHandle::MessageType, const char* data, size_t) = 0;
+ virtual void didReceiveData(WebSocketHandle*, bool fin, WebSocketHandle::MessageType, const char* data, size_t /* size */) = 0;
// Called when the handle is closed.
// |handle| becomes unavailable once this notification arrives.
- virtual void didClose(WebSocketHandle* /* handle */, bool wasClean, unsigned short code, const String& reason) = 0;
+ virtual void didClose(WebSocketHandle* /* handle */, bool wasClean, unsigned short code, const WebString& reason) = 0;
virtual void didReceiveFlowControl(WebSocketHandle*, int64_t quota) = 0;

Powered by Google App Engine
This is Rietveld 408576698