Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2279703002: Add a scoped context object for synchronous CE creation (Closed)

Created:
4 years, 3 months ago by kochi
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a scoped context object for synchronous CE creation In synchronous custom element creation (e.g. document.createElement('my-element')), context object is not passed down to the constructor. CustomElementCreationScope manages a scoped context in LocalDOMWindow. BUG=640465

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 5 chunks +13 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/core/dom/custom/CustomElementCreationScope.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (14 generated)
kojii
We should probably have CustomElementCreationScope in CustomElement::createCustomElementSync so that callers do not have to take ...
4 years, 3 months ago (2016-08-25 08:14:43 UTC) #13
kochi
4 years, 3 months ago (2016-08-25 09:32:24 UTC) #16
On 2016/08/25 08:14:43, kojii wrote:
> We should probably have CustomElementCreationScope in
> CustomElement::createCustomElementSync so that callers do not have to take
care
> of it. Doing so will probably make this CL as small as the other candidate.
> 
> The other one shares more code between create and upgrade, so I have mild
> preference to it, but I might be biased by it's my CL? WDYT?

Yeah, your change seems more streamlined and even unifies two
paths (upgrade/create), so let's go for yours.

Powered by Google App Engine
This is Rietveld 408576698