Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2279693002: Fix typos in custom element + imports layout tests (Closed)

Created:
4 years, 3 months ago by kochi
Modified:
4 years, 3 months ago
Reviewers:
kojii
CC:
blink-reviews, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typos in custom element + imports layout tests These tests are currently disabled by TestExpectation for failing, but will be enabled again in the following CLs. BUG=594918 Committed: https://crrev.com/b0b6d8bd55f2530eef49f697330cd908769ef54d Cr-Commit-Position: refs/heads/master@{#414360}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 11 (6 generated)
kochi
FYI, this is not for submit. https://codereview.chromium.org/2279693002/diff/1/third_party/WebKit/LayoutTests/custom-elements/imports/resources/create-element.html File third_party/WebKit/LayoutTests/custom-elements/imports/resources/create-element.html (right): https://codereview.chromium.org/2279693002/diff/1/third_party/WebKit/LayoutTests/custom-elements/imports/resources/create-element.html#newcode34 third_party/WebKit/LayoutTests/custom-elements/imports/resources/create-element.html:34: assert_equals(constructors.length, 3); This ...
4 years, 3 months ago (2016-08-25 06:18:33 UTC) #2
kojii
lgtm
4 years, 3 months ago (2016-08-25 06:57:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279693002/1
4 years, 3 months ago (2016-08-25 06:58:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 08:22:40 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 08:25:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0b6d8bd55f2530eef49f697330cd908769ef54d
Cr-Commit-Position: refs/heads/master@{#414360}

Powered by Google App Engine
This is Rietveld 408576698