Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2279293002: Return null when selected text is empty (Closed)

Created:
4 years, 3 months ago by Changwan Ryu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return null when selected text is empty InputConnection#getSelectedText() should return null when the selection is empty. ThreadedInputConnection was not doing this correctly, and confused some OEM keyboards. BUG=638201 Committed: https://crrev.com/fe62ee1b4b965d3c63bee8f2d0df160ae4529ae0 Cr-Commit-Position: refs/heads/master@{#414821}

Patch Set 1 #

Patch Set 2 : Return null when selected text is empty #

Patch Set 3 : fixed a failing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 2 16 chunks +20 lines, -24 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/input/TextInputStateTest.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Changwan Ryu
PTAL
4 years, 3 months ago (2016-08-26 15:17:12 UTC) #4
Ted C
lgtm
4 years, 3 months ago (2016-08-26 16:18:07 UTC) #5
aelias_OOO_until_Jul13
lgtm
4 years, 3 months ago (2016-08-26 18:54:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279293002/40001
4 years, 3 months ago (2016-08-26 20:52:51 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-26 21:45:52 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:48:31 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe62ee1b4b965d3c63bee8f2d0df160ae4529ae0
Cr-Commit-Position: refs/heads/master@{#414821}

Powered by Google App Engine
This is Rietveld 408576698