content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java - Issue 2279293002: Return null when selected text is empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java

Issue 2279293002: Return null when selected text is empty (Closed)

Patch Set: fixed a failing test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java b/content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java

index 444f23c474d546208d7fff488f8004f5e37d10f6..38684dfc9d9cfac2a51d79f0e630417255073812 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java

@@ -53,6 +53,7 @@ public class TextInputState {

}

public CharSequence getSelectedText() {

+ if (mSelection.start() == mSelection.end()) return null;

return TextUtils.substring(mText, mSelection.start(), mSelection.end());

}

« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »