Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2279203003: Converted Observatory megamorphiccache-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated observatory_sources.gypi #

Total comments: 2

Patch Set 3 : Removed double Copyright notice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -92 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_view.dart View 1 2 1 chunk +171 lines, -8 lines 0 comments Download
D runtime/observatory/lib/src/elements/megamorphiccache_view.html View 1 chunk +0 lines, -55 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/megamorphiccache.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/megamorphiccache.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/megamorphiccache.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 3 chunks +2 lines, -1 line 0 comments Download
A + runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart View 2 chunks +16 lines, -14 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/megamorphiccache.dart View 1 chunk +16 lines, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/megamorphiccache.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-26 19:51:12 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2279203003/diff/20001/runtime/observatory/lib/src/elements/megamorphiccache_view.dart File runtime/observatory/lib/src/elements/megamorphiccache_view.dart (right): https://codereview.chromium.org/2279203003/diff/20001/runtime/observatory/lib/src/elements/megamorphiccache_view.dart#newcode7 runtime/observatory/lib/src/elements/megamorphiccache_view.dart:7: // Copyright (c) 2013, the Dart project authors. ...
4 years, 3 months ago (2016-08-26 21:17:48 UTC) #3
cbernaschina
https://codereview.chromium.org/2279203003/diff/20001/runtime/observatory/lib/src/elements/megamorphiccache_view.dart File runtime/observatory/lib/src/elements/megamorphiccache_view.dart (right): https://codereview.chromium.org/2279203003/diff/20001/runtime/observatory/lib/src/elements/megamorphiccache_view.dart#newcode7 runtime/observatory/lib/src/elements/megamorphiccache_view.dart:7: // Copyright (c) 2013, the Dart project authors. Please ...
4 years, 3 months ago (2016-08-26 22:18:24 UTC) #4
cbernaschina
4 years, 3 months ago (2016-08-26 22:23:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
5e1b224ef8fda4d7a00adce198d6f5d20f64417a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698