Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart

Issue 2279203003: Converted Observatory megamorphiccache-view element (Closed)
Patch Set: Removed double Copyright notice Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/icdata_view/element_test.dart b/runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart
similarity index 63%
copy from runtime/observatory/tests/observatory_ui/icdata_view/element_test.dart
copy to runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart
index cde932c50ac628dbb581410aa0eb65e88f055acd..06f3d657d3d2ecd27c2da2fbe91a41039a50b79d 100644
--- a/runtime/observatory/tests/observatory_ui/icdata_view/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart
@@ -4,13 +4,13 @@
import 'dart:html';
import 'package:unittest/unittest.dart';
-import 'package:observatory/src/elements/icdata_view.dart';
+import 'package:observatory/src/elements/megamorphiccache_view.dart';
import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/object_common.dart';
import '../mocks.dart';
main() {
- ICDataViewElement.tag.ensureRegistration();
+ MegamorphicCacheViewElement.tag.ensureRegistration();
final cTag = ObjectCommonElement.tag.name;
final rTag = NavRefreshElement.tag.name;
@@ -19,32 +19,34 @@ main() {
const isolate = const IsolateRefMock();
final events = new EventRepositoryMock();
final notifs = new NotificationRepositoryMock();
- final icdata = const ICDataMock();
- final icdatas = new ICDataRepositoryMock();
+ final cache = const MegamorphicCacheMock();
+ final caches = new MegamorphicCacheRepositoryMock();
final reachableSizes = new ReachableSizeRepositoryMock();
final retainedSizes = new RetainedSizeRepositoryMock();
final inbounds = new InboundReferencesRepositoryMock();
final paths = new RetainingPathRepositoryMock();
final instances = new InstanceRepositoryMock();
test('instantiation', () {
- final e = new ICDataViewElement(vm, isolate, icdata, events, notifs,
- icdatas, retainedSizes, reachableSizes,
- inbounds, paths, instances);
+ final e = new MegamorphicCacheViewElement(vm, isolate, cache, events,
+ notifs, caches, retainedSizes,
+ reachableSizes, inbounds, paths,
+ instances);
expect(e, isNotNull, reason: 'element correctly created');
expect(e.isolate, equals(isolate));
- expect(e.icdata, equals(icdata));
+ expect(e.cache, equals(cache));
});
test('elements created after attachment', () async {
- final icdatas = new ICDataRepositoryMock(
+ final caches = new MegamorphicCacheRepositoryMock(
getter: expectAsync((i, id) async {
expect(i, equals(isolate));
- expect(id, equals(icdata.id));
- return icdata;
+ expect(id, equals(cache.id));
+ return cache;
}, count: 1)
);
- final e = new ICDataViewElement(vm, isolate, icdata, events, notifs,
- icdatas, retainedSizes, reachableSizes,
- inbounds, paths, instances);
+ final e = new MegamorphicCacheViewElement(vm, isolate, cache, events,
+ notifs, caches, retainedSizes,
+ reachableSizes, inbounds, paths,
+ instances);
document.body.append(e);
await e.onRendered.first;
expect(e.children.length, isNonZero, reason: 'has elements');

Powered by Google App Engine
This is Rietveld 408576698