sdk/lib/_internal/compiler/implementation/compiler.dart - Issue 22791002: Add renames in output when using the mirror helper library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 22791002: Add renames in output when using the mirror helper library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Changed solution approach. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart » ('j') | sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/compiler.dart

diff --git a/sdk/lib/_internal/compiler/implementation/compiler.dart b/sdk/lib/_internal/compiler/implementation/compiler.dart

index 91ee72a610f4ca239c2f7af099de85bd360d2392..92f798d42e0d8d592d33c4270b686fa15569a0b8 100644

--- a/sdk/lib/_internal/compiler/implementation/compiler.dart

+++ b/sdk/lib/_internal/compiler/implementation/compiler.dart

@@ -394,6 +394,7 @@ abstract class Compiler implements DiagnosticListener {

LibraryElement interceptorsLibrary;

LibraryElement foreignLibrary;

LibraryElement mainApp;

+ LibraryElement mirrorHelperLibrary;

ahe 2013/08/19 15:34:06 Could you move this to the backend?

ahe 2013/08/19 15:34:06 Document this field, see [mirrorsLibrary].

zarah 2013/08/20 14:08:17 Done.

/// Initialized when dart:mirrors is loaded.

LibraryElement mirrorsLibrary;

@@ -447,6 +448,7 @@ abstract class Compiler implements DiagnosticListener {

Element functionApplyMethod;

Element invokeOnMethod;

Element createInvocationMirrorElement;

+ FunctionElement mirrorHelperFunction;

ahe 2013/08/19 15:34:06 Could this also be moved to the backend?

ahe 2013/08/19 15:34:06 More descriptive name and documentation. See [symb

zarah 2013/08/20 14:08:17 Done.

Element get currentElement => _currentElement;