Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 22791002: Add renames in output when using the mirror helper library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Changed solution approach. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 /** 7 /**
8 * If true, print a warning for each method that was resolved, but not 8 * If true, print a warning for each method that was resolved, but not
9 * compiled. 9 * compiled.
10 */ 10 */
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 387
388 CompilerTask measuredTask; 388 CompilerTask measuredTask;
389 Element _currentElement; 389 Element _currentElement;
390 LibraryElement coreLibrary; 390 LibraryElement coreLibrary;
391 LibraryElement isolateLibrary; 391 LibraryElement isolateLibrary;
392 LibraryElement isolateHelperLibrary; 392 LibraryElement isolateHelperLibrary;
393 LibraryElement jsHelperLibrary; 393 LibraryElement jsHelperLibrary;
394 LibraryElement interceptorsLibrary; 394 LibraryElement interceptorsLibrary;
395 LibraryElement foreignLibrary; 395 LibraryElement foreignLibrary;
396 LibraryElement mainApp; 396 LibraryElement mainApp;
397 LibraryElement mirrorHelperLibrary;
ahe 2013/08/19 15:34:06 Could you move this to the backend?
ahe 2013/08/19 15:34:06 Document this field, see [mirrorsLibrary].
zarah 2013/08/20 14:08:17 Done.
zarah 2013/08/20 14:08:17 Done.
397 398
398 /// Initialized when dart:mirrors is loaded. 399 /// Initialized when dart:mirrors is loaded.
399 LibraryElement mirrorsLibrary; 400 LibraryElement mirrorsLibrary;
400 401
401 ClassElement objectClass; 402 ClassElement objectClass;
402 ClassElement closureClass; 403 ClassElement closureClass;
403 ClassElement boundClosureClass; 404 ClassElement boundClosureClass;
404 ClassElement dynamicClass; 405 ClassElement dynamicClass;
405 ClassElement boolClass; 406 ClassElement boolClass;
406 ClassElement numClass; 407 ClassElement numClass;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
440 ClassElement deferredLibraryClass; 441 ClassElement deferredLibraryClass;
441 442
442 ClassElement jsInvocationMirrorClass; 443 ClassElement jsInvocationMirrorClass;
443 /// Document class from dart:mirrors. 444 /// Document class from dart:mirrors.
444 ClassElement documentClass; 445 ClassElement documentClass;
445 Element assertMethod; 446 Element assertMethod;
446 Element identicalFunction; 447 Element identicalFunction;
447 Element functionApplyMethod; 448 Element functionApplyMethod;
448 Element invokeOnMethod; 449 Element invokeOnMethod;
449 Element createInvocationMirrorElement; 450 Element createInvocationMirrorElement;
451 FunctionElement mirrorHelperFunction;
ahe 2013/08/19 15:34:06 Could this also be moved to the backend?
ahe 2013/08/19 15:34:06 More descriptive name and documentation. See [symb
zarah 2013/08/20 14:08:17 Done.
zarah 2013/08/20 14:08:17 Done.
450 452
451 Element get currentElement => _currentElement; 453 Element get currentElement => _currentElement;
452 454
453 /** 455 /**
454 * Perform an operation, [f], returning the return value from [f]. If an 456 * Perform an operation, [f], returning the return value from [f]. If an
455 * error occurs then report it as having occurred during compilation of 457 * error occurs then report it as having occurred during compilation of
456 * [element]. Can be nested. 458 * [element]. Can be nested.
457 */ 459 */
458 withCurrentElement(Element element, f()) { 460 withCurrentElement(Element element, f()) {
459 Element old = currentElement; 461 Element old = currentElement;
(...skipping 1068 matching lines...) Expand 10 before | Expand all | Expand 10 after
1528 1530
1529 void close() {} 1531 void close() {}
1530 1532
1531 toString() => name; 1533 toString() => name;
1532 1534
1533 /// Convenience method for getting an [api.CompilerOutputProvider]. 1535 /// Convenience method for getting an [api.CompilerOutputProvider].
1534 static NullSink outputProvider(String name, String extension) { 1536 static NullSink outputProvider(String name, String extension) {
1535 return new NullSink('$name.$extension'); 1537 return new NullSink('$name.$extension');
1536 } 1538 }
1537 } 1539 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698