Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2278973002: [modules] Rename ModuleDescriptor::ModuleEntry to ModuleDescriptor::Entry. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Rename ModuleDescriptor::ModuleEntry to ModuleDescriptor::Entry. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/a45d106db0eaf46349e82f6541a30e8b55b524cb Cr-Commit-Position: refs/heads/master@{#38924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -54 lines) Patch
M src/ast/modules.h View 2 chunks +11 lines, -13 lines 0 comments Download
M src/ast/modules.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +29 lines, -30 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
neis
4 years, 3 months ago (2016-08-25 12:51:37 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-08-25 15:50:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278973002/1
4 years, 3 months ago (2016-08-26 07:01:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 07:04:05 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 07:04:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a45d106db0eaf46349e82f6541a30e8b55b524cb
Cr-Commit-Position: refs/heads/master@{#38924}

Powered by Google App Engine
This is Rietveld 408576698