[modules] Partial support for (de-)serializing module descriptor entries.

[modules] Partial support for (de-)serializing module descriptor entries.

This will be used for scope infos in a follow-up CL.

R=adamk@chromium.org
BUG=v8:1569
Committed: https://crrev.com/98a79c9412accd4fc9b806b2e52870230cf24094
Cr-Commit-Position: refs/heads/master@{#38969}

[neis, 2016-08-25 13:14:07]

PTAL

[neis, 2016-08-25 13:57:17]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 13:57:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 14:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 14:26:48]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-25 15:56:20]

https://codereview.chromium.org/2277273002/diff/20001/src/ast/modules.cc
File src/ast/modules.cc (right):

https://codereview.chromium.org/2277273002/diff/20001/src/ast/modules.cc#newc...
src/ast/modules.cc:91: Handle<FixedArray> result =
isolate->factory()->NewFixedArray(4);
Do you plan to always used a FixedArray for this or is this just temporary?

https://codereview.chromium.org/2277273002/diff/20001/src/ast/modules.h
File src/ast/modules.h (right):

https://codereview.chromium.org/2277273002/diff/20001/src/ast/modules.h#newco...
src/ast/modules.h:115: void AddRegularExport(Entry* entry) {
Can these methods be private?

[neis, 2016-08-26 07:28:03]

https://codereview.chromium.org/2277273002/diff/20001/src/ast/modules.cc
File src/ast/modules.cc (right):

https://codereview.chromium.org/2277273002/diff/20001/src/ast/modules.cc#newc...
src/ast/modules.cc:91: Handle<FixedArray> result =
isolate->factory()->NewFixedArray(4);
On 2016/08/25 15:56:19, adamk wrote:
> Do you plan to always used a FixedArray for this or is this just temporary?

I don't mind using something else when I see the need.

https://codereview.chromium.org/2277273002/diff/20001/src/ast/modules.h
File src/ast/modules.h (right):

https://codereview.chromium.org/2277273002/diff/20001/src/ast/modules.h#newco...
src/ast/modules.h:115: void AddRegularExport(Entry* entry) {
On 2016/08/25 15:56:20, adamk wrote:
> Can these methods be private?

No, they are used by the ModuleScope constructor when deserializing a scope
info. See https://codereview.chromium.org/2277253003/

[adamk, 2016-08-26 17:12:00]

lgtm

[neis, 2016-08-29 08:51:37]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-29 08:51:37]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2277273002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-29 08:51:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 09:15:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-29 09:15:52]

Description was changed from

==========
[modules] Partial support for (de-)serializing module descriptor entries.

This will be used for scope infos in a follow-up CL.

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Partial support for (de-)serializing module descriptor entries.

This will be used for scope infos in a follow-up CL.

R=adamk@chromium.org
BUG=v8:1569

Committed: https://crrev.com/98a79c9412accd4fc9b806b2e52870230cf24094
Cr-Commit-Position: refs/heads/master@{#38969}
==========

[commit-bot: I haz the power, 2016-08-29 09:15:53]

Patchset 3 (id:??) landed as
https://crrev.com/98a79c9412accd4fc9b806b2e52870230cf24094
Cr-Commit-Position: refs/heads/master@{#38969}