Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2278783002: Add 80% and 250% zoom level to settings. (Closed)

Created:
4 years, 3 months ago by Bret
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 80% and 250% zoom level to settings. https://codereview.chromium.org/2263733002 added 80% zoom to the list of presets, but I forgot it in the settings dropdown. And it looks like 250% was missing from the settings too, for some reason. I can't find anything to indicate this was intentional, so I included it as well. Also updated the comments so that no one else makes this mistake. BUG=632323 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/24e7ec450709151344f63e2b273ec5266e1426f6 Cr-Commit-Position: refs/heads/master@{#414251}

Patch Set 1 #

Patch Set 2 : add 250% and update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/resources/pdf/viewport.js View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.js View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/zoom/page_zoom_constants.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Bret
4 years, 3 months ago (2016-08-24 23:24:40 UTC) #4
Dan Beam
heh, lgtm
4 years, 3 months ago (2016-08-24 23:30:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278783002/20001
4 years, 3 months ago (2016-08-24 23:38:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 02:11:46 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 02:16:14 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24e7ec450709151344f63e2b273ec5266e1426f6
Cr-Commit-Position: refs/heads/master@{#414251}

Powered by Google App Engine
This is Rietveld 408576698