Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2263733002: Change zoom presets to be more useful. (Closed)

Created:
4 years, 4 months ago by Bret
Modified:
4 years, 4 months ago
Reviewers:
wjmaclean, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change zoom presets to be more useful. Device pixel ratio at 1.25 and 1.5 device scale factors are problematic for existing zoom levels. In particular there was no 80% zoom level that allowed users with 1.25 set to achieve a dpr of 1 (i.e. equivalent to no zoom or dsf). Also 1/3 and 2/3 were set to 0.333 and 0.666 instead of their more precise representations, which caused the math to be slightly off when using those (especially important for 1.5 dsf, because 2/3 is needed to achieve a dpr of 1). This patch fixes both of these issues. R=dbeam@chromium.org BUG=632323 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9924b8460b425396e9ca518775da1d013b69cdff Cr-Commit-Position: refs/heads/master@{#413494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/pdf/viewport.js View 1 chunk +2 lines, -2 lines 0 comments Download
M components/zoom/page_zoom_constants.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Bret
4 years, 4 months ago (2016-08-19 23:49:41 UTC) #4
Dan Beam
ehh seems legit to me lgtm
4 years, 4 months ago (2016-08-20 01:33:42 UTC) #5
wjmaclean
On 2016/08/20 01:33:42, Dan Beam wrote: > ehh seems legit to me lgtm Seems ok ...
4 years, 4 months ago (2016-08-22 16:46:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263733002/1
4 years, 4 months ago (2016-08-22 17:36:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 18:57:30 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 19:04:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9924b8460b425396e9ca518775da1d013b69cdff
Cr-Commit-Position: refs/heads/master@{#413494}

Powered by Google App Engine
This is Rietveld 408576698