Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2278743002: Disallow non-postive sizes in vector icon views example. (Closed)

Created:
4 years, 4 months ago by Peter Kasting
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow non-postive sizes in vector icon views example. This is mostly a follow-up to an unintentional behavior change in https://codereview.chromium.org/2255403002/ . I decided to treat 0 size as invalid as well. BUG=none TEST=none Committed: https://crrev.com/bb2232919d039876cbc4181282a620caa4d32592 Cr-Commit-Position: refs/heads/master@{#414215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/examples/vector_example.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Peter Kasting
This change is blind, because I can't launch views_examples_exe. See https://bugs.chromium.org/p/chromium/issues/detail?id=640748 .
4 years, 4 months ago (2016-08-24 21:23:17 UTC) #4
sky
LGTM
4 years, 3 months ago (2016-08-24 23:15:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278743002/1
4 years, 3 months ago (2016-08-25 00:15:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 00:21:13 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 00:22:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb2232919d039876cbc4181282a620caa4d32592
Cr-Commit-Position: refs/heads/master@{#414215}

Powered by Google App Engine
This is Rietveld 408576698