Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1821)

Unified Diff: components/metrics/export/metric_sample.cc

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Running tests only for chromeos. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/export/metric_sample.cc
diff --git a/components/metrics/export/metric_sample.cc b/components/metrics/export/metric_sample.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b9331787754539c11ca106c963c410bb4d39afde
--- /dev/null
+++ b/components/metrics/export/metric_sample.cc
@@ -0,0 +1,25 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/metrics/export/metric_sample.h"
+
+#include <string>
+
+using std::string;
+
+namespace metrics {
Alexei Svitkine (slow) 2014/04/30 15:25:24 Nit: Add a blank line after this.
bsimonnet 2014/04/30 20:28:40 Done.
+MetricSample::MetricSample(MetricSample::SampleType sample_type,
+ const string& metric_name)
+ : type_(sample_type), name_(metric_name) {}
+
+MetricSample::~MetricSample() {}
+
+bool MetricSample::IsValid() const {
+ return name().find(' ') == string::npos &&
+ name().find('\0') == string::npos && name().length() > 0;
+}
+
+string MetricSample::ToString() const { return "not implemented"; }
Alexei Svitkine (slow) 2014/04/30 15:25:24 Put method body on separate line.
bsimonnet 2014/04/30 20:28:40 Done.
+
+} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698