components/metrics/export/metric_sample.cc - Issue 227873002: Create a histogram serialization mechanism in components/metrics

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/metrics/export/metric_sample.cc

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Running tests only for chromeos. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/metrics/export/metric_sample.h ('K') | « components/metrics/export/metric_sample.h ('k') | components/metrics/export/metrics_utils.h » ('j') | components/metrics/export/metrics_utils.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/metrics/export/metric_sample.h"

	6

	7 #include <string>

	8

	9 using std::string;

	10

	11 namespace metrics {
	Alexei Svitkine (slow) 2014/04/30 15:25:24 Nit: Add a blank line after this. Nit: Add a blank line after this. bsimonnet 2014/04/30 20:28:40 Done. Show quoted text On 2014/04/30 15:25:24, Alexei Svitkine wrote: > Nit: Add a blank line after this. Done.
	12 MetricSample::MetricSample(MetricSample::SampleType sample_type,

	13 const string& metric_name)

	14 : type_(sample_type), name_(metric_name) {}

	15

	16 MetricSample::~MetricSample() {}

	17

	18 bool MetricSample::IsValid() const {

	19 return name().find(' ') == string::npos &&

	20 name().find('\0') == string::npos && name().length() > 0;

	21 }

	22

	23 string MetricSample::ToString() const { return "not implemented"; }
	Alexei Svitkine (slow) 2014/04/30 15:25:24 Put method body on separate line. Put method body on separate line. bsimonnet 2014/04/30 20:28:40 Done. Show quoted text On 2014/04/30 15:25:24, Alexei Svitkine wrote: > Put method body on separate line. Done.
	24

	25 } // namespace metrics

OLD	NEW