Revert of clang plugin: Remove check-templates toggle.

Revert of clang plugin: Remove check-templates toggle. (patchset #1 id:1 of https://codereview.chromium.org/2267713003/ )

Reason for revert:
This broke the weak_ptr_factory.cpp test: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/steps/gclient%20runhooks/logs/stdio

I think this check effectively always disabled the check-templates flag instead of always enabling it.

And it sucks that we didn't notice for two days :-(

Original issue's description:
> clang plugin: Remove check-templates toggle.
>
> It's been on by default for a long time.
>
> BUG=441916
>
> Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
> Cr-Commit-Position: refs/heads/master@{#413546}

TBR=dcheng@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=441916
Committed: https://crrev.com/6848faac88b90757120621a59760e5f98fd8dd89
Cr-Commit-Position: refs/heads/master@{#414216}

[hans, 2016-08-24 23:33:09]

The CQ bit was checked by hans@chromium.org

[hans, 2016-08-24 23:33:10]

Created Revert of clang plugin: Remove check-templates toggle.

[commit-bot: I haz the power, 2016-08-24 23:34:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:27:34]

Description was changed from

==========
Revert of clang plugin: Remove check-templates toggle. (patchset #1 id:1 of
https://codereview.chromium.org/2267713003/ )

Reason for revert:
This broke the weak_ptr_factory.cpp test:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/...

I think this check effectively always disabled the check-templates flag instead
of always enabling it.

And it sucks that we didn't notice for two days :-(

Original issue's description:
> clang plugin: Remove check-templates toggle.
> 
> It's been on by default for a long time.
> 
> BUG=441916
> 
> Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
> Cr-Commit-Position: refs/heads/master@{#413546}

TBR=dcheng@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=441916
==========

to

==========
Revert of clang plugin: Remove check-templates toggle. (patchset #1 id:1 of
https://codereview.chromium.org/2267713003/ )

Reason for revert:
This broke the weak_ptr_factory.cpp test:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/...

I think this check effectively always disabled the check-templates flag instead
of always enabling it.

And it sucks that we didn't notice for two days :-(

Original issue's description:
> clang plugin: Remove check-templates toggle.
> 
> It's been on by default for a long time.
> 
> BUG=441916
> 
> Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
> Cr-Commit-Position: refs/heads/master@{#413546}

TBR=dcheng@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=441916
==========

[commit-bot: I haz the power, 2016-08-25 00:27:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-25 00:29:04]

Description was changed from

==========
Revert of clang plugin: Remove check-templates toggle. (patchset #1 id:1 of
https://codereview.chromium.org/2267713003/ )

Reason for revert:
This broke the weak_ptr_factory.cpp test:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/...

I think this check effectively always disabled the check-templates flag instead
of always enabling it.

And it sucks that we didn't notice for two days :-(

Original issue's description:
> clang plugin: Remove check-templates toggle.
> 
> It's been on by default for a long time.
> 
> BUG=441916
> 
> Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
> Cr-Commit-Position: refs/heads/master@{#413546}

TBR=dcheng@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=441916
==========

to

==========
Revert of clang plugin: Remove check-templates toggle. (patchset #1 id:1 of
https://codereview.chromium.org/2267713003/ )

Reason for revert:
This broke the weak_ptr_factory.cpp test:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/...

I think this check effectively always disabled the check-templates flag instead
of always enabling it.

And it sucks that we didn't notice for two days :-(

Original issue's description:
> clang plugin: Remove check-templates toggle.
>
> It's been on by default for a long time.
>
> BUG=441916
>
> Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
> Cr-Commit-Position: refs/heads/master@{#413546}

TBR=dcheng@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=441916

Committed: https://crrev.com/6848faac88b90757120621a59760e5f98fd8dd89
Cr-Commit-Position: refs/heads/master@{#414216}
==========

[commit-bot: I haz the power, 2016-08-25 00:29:05]

Patchset 1 (id:??) landed as
https://crrev.com/6848faac88b90757120621a59760e5f98fd8dd89
Cr-Commit-Position: refs/heads/master@{#414216}