tools/clang/plugins/FindBadConstructsConsumer.cpp - Issue 2278603004: Revert of clang plugin: Remove check-templates toggle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/FindBadConstructsConsumer.cpp

Issue 2278603004: Revert of clang plugin: Remove check-templates toggle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/plugins/FindBadConstructsConsumer.cpp

diff --git a/tools/clang/plugins/FindBadConstructsConsumer.cpp b/tools/clang/plugins/FindBadConstructsConsumer.cpp

index 8cbb94f6a00efb902cdb69ff9a9677ac8953f292..0cb0a08820437fa3ca8cb68a59f892e681f107c6 100644

--- a/tools/clang/plugins/FindBadConstructsConsumer.cpp

+++ b/tools/clang/plugins/FindBadConstructsConsumer.cpp

@@ -221,7 +221,7 @@

// That was only a mistake; once Chromium code passes these checks, we should

// remove the "check-templates" option and remove this code.

// See crbug.com/441916

- if (IsPodOrTemplateType(*record))

+ if (!options_.check_templates && IsPodOrTemplateType(*record))

return;

bool implementation_file = InImplementationFile(record_location);

« no previous file with comments | « tools/clang/plugins/FindBadConstructsAction.cpp ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »