Issue 2278433002: Remove redundant IsEmpty() checks for toV8()

Issue 2278433002: Remove redundant IsEmpty() checks for toV8() (Closed)

Created:
4 years, 4 months ago by haraken

Modified:
4 years, 4 months ago

Reviewers:
Yuki

CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove redundant IsEmpty() checks for toV8() Now toV8() never reutns an empty value. BUG=625512 Committed: https://crrev.com/9cf0f0b1dafb8c696428511df48f3a98723ad50d Cr-Commit-Position: refs/heads/master@{#414037}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -105 lines)			Patch
M	third_party/WebKit/Source/bindings/templates/attributes.cpp	View	3 chunks	+2 lines, -11 lines	0 comments	Download
M	third_party/WebKit/Source/bindings/templates/methods.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp	View	4 chunks	+2 lines, -13 lines	0 comments	Download
M	third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp	View	24 chunks	+12 lines, -78 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278433002/1

4 years, 4 months ago (2016-08-24 07:04:48 UTC) #5

commit-bot: I haz the power

4 years, 4 months ago (2016-08-24 10:25:12 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9cf0f0b1dafb8c696428511df48f3a98723ad50d
Cr-Commit-Position: refs/heads/master@{#414037}