third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp - Issue 2278433002: Remove redundant IsEmpty() checks for toV8()

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 2278433002: Remove redundant IsEmpty() checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/methods.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

index 8e099c63d25560c9934e6f252d1310e81c0e1403..3f73210162729cc43fcd4491384d69d892264b71 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

@@ -393,10 +393,8 @@ static void staticReadOnlyReturnDOMWrapperAttributeAttributeGetter(const v8::Fun

if (cppValue && DOMDataStore::setReturnValue(info.GetReturnValue(), cppValue))

return;

v8::Local<v8::Value> v8Value(toV8(cppValue, holder, info.GetIsolate()));

- if (!v8Value.IsEmpty()) {

- V8HiddenValue::setHiddenValue(ScriptState::current(info.GetIsolate()), holder, v8AtomicString(info.GetIsolate(), "staticReadOnlyReturnDOMWrapperAttribute"), v8Value);

- v8SetReturnValue(info, v8Value);

- }

+ V8HiddenValue::setHiddenValue(ScriptState::current(info.GetIsolate()), holder, v8AtomicString(info.GetIsolate(), "staticReadOnlyReturnDOMWrapperAttribute"), v8Value);

+ v8SetReturnValue(info, v8Value);

}

static void staticReadOnlyReturnDOMWrapperAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

@@ -2982,9 +2980,6 @@ bool V8TestInterface::PrivateScript::shortMethodWithShortArgumentImplementedInPr

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

- if (holder.IsEmpty())

- return false;

v8::Local<v8::Value> valueHandle = v8::Integer::New(scriptState->isolate(), value);

v8::Local<v8::Value> argv[] = { valueHandle };

ExceptionState exceptionState(ExceptionState::ExecutionContext, "shortMethodWithShortArgumentImplementedInPrivateScript", "TestInterfaceImplementation", scriptState->context()->Global(), scriptState->isolate());

@@ -3014,9 +3009,6 @@ bool V8TestInterface::PrivateScript::stringAttributeAttributeGetter(LocalFrame*

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

- if (holder.IsEmpty())

- return false;

ExceptionState exceptionState(ExceptionState::GetterContext, "stringAttribute", "TestInterfaceImplementation", scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> v8Value = PrivateScriptRunner::runDOMAttributeGetter(scriptState, scriptStateInUserScript, "TestInterfaceImplementation", "stringAttribute", holder);

if (v8Value.IsEmpty())

@@ -3044,9 +3036,6 @@ bool V8TestInterface::PrivateScript::stringAttributeAttributeSetter(LocalFrame*

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

- if (holder.IsEmpty())

- return false;

ExceptionState exceptionState(ExceptionState::SetterContext, "stringAttribute", "TestInterfaceImplementation", scriptState->context()->Global(), scriptState->isolate());

return PrivateScriptRunner::runDOMAttributeSetter(scriptState, scriptStateInUserScript, "TestInterfaceImplementation", "stringAttribute", holder, v8String(scriptState->isolate(), cppValue));

}