Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2278283002: Implement Mac Pop-up Dictionary for OOPIF. (Closed)
Patch Set: Addressing lfg@'s comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 239123de6927ea4f08f3ac23fc9e5ed4c4a64c41..2de5dc5424b362462355bed09c3e0a25d6d92e8a 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -3484,7 +3484,7 @@ TEST_F(WebViewTest, WebSubstringUtil)
ASSERT_TRUE(!!result);
WebPoint point(baselinePoint.x, frameView->height() - baselinePoint.y);
- result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+ result = WebSubstringUtil::attributedWordAtPoint(frame->frameWidget(), point, baselinePoint);
ASSERT_TRUE(!!result);
webView->setZoomLevel(3);
@@ -3493,7 +3493,7 @@ TEST_F(WebViewTest, WebSubstringUtil)
ASSERT_TRUE(!!result);
point = WebPoint(baselinePoint.x, frameView->height() - baselinePoint.y);
- result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+ result = WebSubstringUtil::attributedWordAtPoint(frame->frameWidget(), point, baselinePoint);
ASSERT_TRUE(!!result);
}
@@ -3513,7 +3513,7 @@ TEST_F(WebViewTest, WebSubstringUtilIframe)
ASSERT_NE(result, nullptr);
WebPoint point(baselinePoint.x, mainFrame->frameView()->height() - baselinePoint.y);
- result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+ result = WebSubstringUtil::attributedWordAtPoint(mainFrame->frameWidget(), point, baselinePoint);
ASSERT_NE(result, nullptr);
int yBeforeChange = baselinePoint.y;
@@ -3523,7 +3523,7 @@ TEST_F(WebViewTest, WebSubstringUtilIframe)
"document.querySelector('iframe').style.marginTop = '100px';"));
point = WebPoint(point.x, point.y + 100);
- result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+ result = WebSubstringUtil::attributedWordAtPoint(mainFrame->frameWidget(), point, baselinePoint);
ASSERT_NE(result, nullptr);
EXPECT_EQ(yBeforeChange, baselinePoint.y + 100);
« no previous file with comments | « third_party/WebKit/Source/web/mac/WebSubstringUtil.mm ('k') | third_party/WebKit/public/web/mac/WebSubstringUtil.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698