Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

Issue 2278283002: Implement Mac Pop-up Dictionary for OOPIF. (Closed)
Patch Set: Addressing lfg@'s comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
diff --git a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
index c32db74669ef2c763a1399629e7f4166298cc9fb..49a82e5e9a5c4b22f3049f3b22db6f53d15cfc66 100644
--- a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
+++ b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
@@ -50,11 +50,12 @@
#include "platform/fonts/Font.h"
#include "platform/mac/ColorMac.h"
#include "public/platform/WebRect.h"
+#include "public/web/WebFrameWidget.h"
#include "public/web/WebHitTestResult.h"
+#include "public/web/WebLocalFrame.h"
#include "public/web/WebRange.h"
-#include "public/web/WebView.h"
+#include "web/WebFrameWidgetBase.h"
#include "web/WebLocalFrameImpl.h"
-#include "web/WebViewImpl.h"
using namespace blink;
@@ -136,9 +137,10 @@ WebPoint getBaselinePoint(FrameView* frameView, const EphemeralRange& range, NSA
namespace blink {
-NSAttributedString* WebSubstringUtil::attributedWordAtPoint(WebView* view, WebPoint point, WebPoint& baselinePoint)
+NSAttributedString* WebSubstringUtil::attributedWordAtPoint(WebFrameWidget* frameWidget, WebPoint point, WebPoint& baselinePoint)
{
- HitTestResult result = static_cast<WebViewImpl*>(view)->coreHitTestResultAt(point);
+ HitTestResult result = static_cast<WebFrameWidgetBase*>(frameWidget)->coreHitTestResultAt(point);
+
if (!result.innerNode())
return nil;
LocalFrame* frame = result.innerNode()->document().frame();
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698