Implement Mac Pop-up Dictionary for OOPIF.

content/browser/renderer_host/render_widget_host_view_mac.h

Index: content/browser/renderer_host/render_widget_host_view_mac.h
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h
index c4c33390ff851756cf5d7790815e839ed34c815e..a3f8a367157eab3879d7d1fcd770584b92384890 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.h
+++ b/content/browser/renderer_host/render_widget_host_view_mac.h
@@ -40,6 +40,7 @@
 #include "ui/display/display_observer.h"
 
 namespace content {
+class RenderWidgetHost;

[Charlie Reis, 2016/09/02 21:57:47]

Stale?

[EhsanK, 2016/09/08 17:10:40]

Based on my changes, yes. But I think we should keep it as there are direct
references to RenderWidgetHost throughout the code in this file (lines ~ 258 and
~243).

 class RenderWidgetHostImpl;
 class RenderWidgetHostViewMac;
 class RenderWidgetHostViewMacEditCommandHelper;
@@ -475,6 +476,13 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
   // |TextInputState.type| which is not ui::TEXT_INPUT_TYPE_NONE.
   RenderWidgetHostImpl* GetActiveWidget();
 
+  // Returns the RenderWidgetHostImpl from hit testing at the given point of the
+  // |root_view|. This is used for TextInputClientMac communication with the
+  // right RenderWidgetHostImpl when showing the dictionary pop-up.
+  RenderWidgetHostImpl* GetRenderWidgetHostAtPoint(

[kenrb, 2016/09/06 18:14:48]

I am not sure it is worth adding this method, rather than just having its
callers call
renderWidgetHostView_->GetRenderWidgetHost()->delegate()->GetInputEventRouter()->GetRenderWidgetHostAtPoint().
This expands the class' public API just to encapsulate some nullptr checks.

[EhsanK, 2016/09/08 17:10:39]

Acknowledged.

+      const gfx::Point& point,
+      gfx::Point* transformed_point);
+
  private:
   friend class RenderWidgetHostViewMacTest;