Implement Mac Pop-up Dictionary for OOPIF.

content/browser/renderer_host/render_widget_host_view_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_H_
 
 #import <Cocoa/Cocoa.h>
 #include <IOSurface/IOSurface.h>
 #include <stddef.h>
@@ skipping 22 matching lines @@
 #include "ipc/ipc_sender.h"
 #include "third_party/WebKit/public/web/WebCompositionUnderline.h"
 #include "ui/accelerated_widget_mac/accelerated_widget_mac.h"
 #include "ui/accelerated_widget_mac/display_link_mac.h"
 #import "ui/base/cocoa/command_dispatcher.h"
 #include "ui/base/cocoa/remote_layer_api.h"
 #import "ui/base/cocoa/tool_tip_base_view.h"
 #include "ui/display/display_observer.h"
 
 namespace content {
+class RenderWidgetHost;

[Charlie Reis, 2016/09/02 21:57:47]

Stale?

[EhsanK, 2016/09/08 17:10:40]

Based on my changes, yes. But I think we should keep it as there are direct
references to RenderWidgetHost throughout the code in this file (lines ~ 258 and
~243).

 class RenderWidgetHostImpl;
 class RenderWidgetHostViewMac;
 class RenderWidgetHostViewMacEditCommandHelper;
 class WebContents;
 struct TextInputState;
 }
 
 namespace ui {
 class Compositor;
 class Layer;
@@ skipping 415 matching lines @@
 
   // Helper method to obtain ui::TextInputType for the active widget from the
   // TextInputManager.
   ui::TextInputType GetTextInputType();
 
   // Helper method to obtain the currently active widget from TextInputManager.
   // An active widget is a RenderWidget which is currently focused and has a
   // |TextInputState.type| which is not ui::TEXT_INPUT_TYPE_NONE.
   RenderWidgetHostImpl* GetActiveWidget();
 
+  // Returns the RenderWidgetHostImpl from hit testing at the given point of the
+  // |root_view|. This is used for TextInputClientMac communication with the
+  // right RenderWidgetHostImpl when showing the dictionary pop-up.
+  RenderWidgetHostImpl* GetRenderWidgetHostAtPoint(

[kenrb, 2016/09/06 18:14:48]

I am not sure it is worth adding this method, rather than just having its
callers call
renderWidgetHostView_->GetRenderWidgetHost()->delegate()->GetInputEventRouter()->GetRenderWidgetHostAtPoint().
This expands the class' public API just to encapsulate some nullptr checks.

[EhsanK, 2016/09/08 17:10:39]

Acknowledged.

+      const gfx::Point& point,
+      gfx::Point* transformed_point);
+
  private:
   friend class RenderWidgetHostViewMacTest;
 
   // Returns whether this render view is a popup (autocomplete window).
   bool IsPopup() const;
 
   // Shuts down the render_widget_host_.  This is a separate function so we can
   // invoke it from the message loop.
   void ShutdownHost();
 
@@ skipping 53 matching lines @@
 
   // Factory used to safely scope delayed calls to ShutdownHost().
   base::WeakPtrFactory<RenderWidgetHostViewMac> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewMac);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_H_