Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2278193002:
Legacy-srgb should mean srgb when colorCorrectRendering is enabled. (Closed)
|
Created:
4 years, 3 months ago by zakerinasab Modified:
4 years, 3 months ago Reviewers:
Justin Novosad Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemoving the status of color correction feature from runtime enabled features.
BUG=637381
Committed: https://crrev.com/9a37a3342df856db8c8f8b06751ba93d4ef19ad4
Cr-Commit-Position: refs/heads/master@{#414572}
Patch Set 1 #Patch Set 2 : Remvoing the status of color correction feature from runtime enabled features. #
Messages
Total messages: 23 (11 generated)
Description was changed from ========== A CL landed recently has resolved this issue. BUG=637381 ========== to ========== A CL landed recently has resolved this issue. BUG=637381 ==========
zakerinasab@chromium.org changed reviewers: + junov@chromium.org
On 2016/08/25 18:33:10, zakerinasab wrote: lgtm
The CQ bit was checked by zakerinasab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by zakerinasab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Looks like some of the test failures might be real regressions. I suspect this might be because some tests run with experimental features enabled. Try removing status=experimental on the ColorCorrectRendering feature in RuntimeEnabledFeatures.in
New patch.
The CQ bit was checked by zakerinasab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org Link to the patchset: https://codereview.chromium.org/2278193002/#ps20001 (title: "Remvoing the status of color correction feature from runtime enabled features.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Message was sent while issue was closed.
Description was changed from ========== A CL landed recently has resolved this issue. BUG=637381 ========== to ========== A CL landed recently has resolved this issue. BUG=637381 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== A CL landed recently has resolved this issue. BUG=637381 ========== to ========== A CL landed recently has resolved this issue. BUG=637381 Committed: https://crrev.com/9a37a3342df856db8c8f8b06751ba93d4ef19ad4 Cr-Commit-Position: refs/heads/master@{#414572} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9a37a3342df856db8c8f8b06751ba93d4ef19ad4 Cr-Commit-Position: refs/heads/master@{#414572}
Message was sent while issue was closed.
Description was changed from ========== A CL landed recently has resolved this issue. BUG=637381 Committed: https://crrev.com/9a37a3342df856db8c8f8b06751ba93d4ef19ad4 Cr-Commit-Position: refs/heads/master@{#414572} ========== to ========== Removing the status of color correction feature from runtime enabled features. BUG=637381 Committed: https://crrev.com/9a37a3342df856db8c8f8b06751ba93d4ef19ad4 Cr-Commit-Position: refs/heads/master@{#414572} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
