Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

Issue 2278193002: Legacy-srgb should mean srgb when colorCorrectRendering is enabled. (Closed)
Patch Set: Remvoing the status of color correction feature from runtime enabled features. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
index 4df94a94a13a83acb757a06e593b52ed97f87c85..abf15f25083478ccce3ddd0bfaa0c81b1e5168f5 100644
--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
@@ -79,16 +79,12 @@ sk_sp<SkColorSpace> CanvasRenderingContext::skColorSpace() const
return SkColorSpace::NewRGB(SkColorSpace::kLinear_GammaNamed, tmp->xyz());
}
case kLegacyCanvasColorSpace:
- // TODO(crbug.com/637381): To uncomment the following block of code we need
- // it to not cause a bunch of test failures.
- /*
if (RuntimeEnabledFeatures::colorCorrectRenderingEnabled()) {
// Legacy colorspace ensures color matching with CSS is preserved.
// So if CSS is color corrected from sRGB to display space, then
// canvas must do the same
return SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named);
}
- */
return nullptr;
};
CHECK(false);
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698